Address 24.2 EMPD Issue #10781
Merged
Address 24.2 EMPD Issue #10781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Myoldmopar
commented
Oct 3, 2024
| @@ -249,9 +249,9 @@ void GetMoistureBalanceEMPDInput(EnergyPlusData &state) | |||
|
|
|||
| auto const &constr = state.dataConstruction->Construct(surf.Construction); | |||
| auto const *mat = dynamic_cast<const MaterialEMPD *>(s_mat->materials(constr.LayerPoint(constr.TotLayers))); | |||
| assert(mat != nullptr); | |||
| // assert(mat != nullptr); | |||
There was a problem hiding this comment.
The way things are structured now, it's totally fine for this to result in a nullptr. If the material doesn't have any EMPD properties, that's fine. So we shouldn't do a hard assertion.
|
|
||
| if (mat->mu > 0.0 && surf.Zone > 0) { | ||
| if (mat && mat->mu > 0.0 && surf.Zone > 0) { |
There was a problem hiding this comment.
Instead, let's just check that mat is real before accessing it. This will properly pass if the inside layer has EMPD stuff. And it will properly result in a warning message if the layer does not have EMPD stuff. This works happily now.
There was a problem hiding this comment.
Just curious, why not not the hasEMPD boolean? isn't what it's for?
|
Everything is happy here. OK, merging this and tagging v24.2.1-RC1. Sorry about this, and thanks for reporting it, @jmarrec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Most of the conversation can be found here, but basically, there was an incorrect check that let an invalid configuration pass before 24.2, accidentally segfaulted in 24.2.0, and now fails gracefully (in 24.2.1+).
I don't expect any diffs or failures, so if there are any, this won't be ready. If it's all green, I think it's good to go.